Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto format from git hook #136

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

jamienoss
Copy link
Member

@jamienoss jamienoss commented Jun 5, 2024

It's ok for the hook to check, which it does, but not actually make any changes.

If I suggested otherwise in the past, my bad!

Signed-off-by: James Noss <jnoss@jhu.edu>
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@jamienoss jamienoss self-assigned this Jun 5, 2024
@jamienoss jamienoss marked this pull request as ready for review June 5, 2024 15:08
@jamienoss jamienoss requested a review from a team as a code owner June 5, 2024 15:08
Copy link
Contributor

@ryanhausen ryanhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jamienoss jamienoss merged commit 8cbd03d into main Jun 5, 2024
9 checks passed
@jamienoss jamienoss deleted the dont-format-from-git-hook branch June 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants