Setup (WIP) #1
Merged
Setup (WIP) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamienoss
force-pushed
the
initial_setup
branch
22 times, most recently
from
6ea26f1
to
96f6b96
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
jamienoss
force-pushed
the
initial_setup
branch
4 times, most recently
from
741dd17
to
dd29d6e
Compare
This was referenced Apr 27, 2023
jamienoss
commented
Apr 27, 2023
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Need to populate Orcid IDs for everyone. The "description" field needs to be specific to the package and not the institute as it is templated for this example. Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
jamienoss
force-pushed
the
initial_setup
branch
from
dd29d6e
to
cd44c6a
Compare
ehunter68
previously approved these changes
Apr 27, 2023
amitschang
reviewed
Apr 27, 2023
| include-package-data = true | ||
|
|
||
| [tool.setuptools_scm] | ||
| write_to = "package_name/_version.py" # Replace package_name with actual name (it's just a template). |
There was a problem hiding this comment.
@amitschang tox.ini added.
amitschang
reviewed
Apr 28, 2023
| @@ -0,0 +1,24 @@ | |||
| [flake8] | |||
| max-line-length=127 | |||
There was a problem hiding this comment.
would vote 120 (simply because idies uses such limit elsewhere), but not a strong vote 😄
There was a problem hiding this comment.
I'll address this in #10.
jamienoss
force-pushed
the
initial_setup
branch
3 times, most recently
from
1f3cb00
to
8b0d30c
Compare
Resolves #11 Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
jamienoss
force-pushed
the
initial_setup
branch
from
8b0d30c
to
79eaa35
Compare
amitschang
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
Will need to add docs build and build as multistage.Repo's now public and using readthedocs.io which handles doc builds.Run pytests also?Nah.