Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure and use isort 😍 #14

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Commits on Oct 8, 2020

  1. Configure and use isort 😍

    This should, eventually (with e.g. instructions in the contribution section, CI, etc.) make it easier to contribute to refex without breaking any style things. It also resolves a bunch of bad imports that are bad for various reasons (e.g. not moving the raw_ast import when it was renamed to ast_matchers, or stuff about whether typing is a third-party library, or...)
    
    Pretty much everything looks good. Humongous thanks to @timothycrosley and everyone on [isort issue #1486](PyCQA/isort#1486).
    
    This also lets me ignore the internal linter that keeps bugging me about where refex imports go. One would imagine they should go in the first-party section -- internal linter doesn't agree (for reasons described in that issue), but it's hard to standardize on a lint-unfriendly order without some tool like isort to help back me up.
    
    PiperOrigin-RevId: 336189960
    ssbr authored and copybara-github committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f55bd49 View commit details
    Browse the repository at this point in the history