Update to use Windows zip dists when available #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y're available * See nodejs/node#5995 for support being added
|
Nice. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node project relatively recently (nodejs/node#5995) added Windows zip distributions, and we can use those instead of using the standalone windows binary and pulling the node_modules from the linux distribution.
This simplifies and makes the resulting node installation structure consistent with what the standard installation is on Windows.
This is backwards compatible because it will cause all existing node installations to be recreated because the directory name changed from e.g. "node-v4.5.0-windows-x64" to "node-v4.5.0-win-x64".