fix: Limit title length to 50 characters in cellUpdate function

[Aswanth-c]

Fixed #207

I have replaced <h1> to <textarea> because the contentEditable approach in <h1> did not handle text wrapping efficiently, which leads to an overflow of text like below

[benjreinhart]

Thank you for this PR!! I have a couple notes:

I know #207 says 50 characters, but we already have one area of validation in the code base for this that uses 44 characters. I prefer 44 for now because that was chosen for a reason previously, though in either case the validation will need to be consistent.

[versecafe]

Why not just allow long names and CSS truncate the text to ... to allow people to easily paste things in without hitting validation issues?

[benjreinhart]

@versecafe we could, and we do this in other places. But given that there's no where in the UI where we render a long title in its entirety, there seems to be no point in allowing one in the first place. IMO, not needing to truncate at all is better than truncating

[benjreinhart]

Would it be easy to reuse the zod schema in all the places where we do validation? If so, can we make that change? That'll make it easier on our future selves when maintaining this.

[benjreinhart]

This allows users to type in a long heading but then it disappears on blur with a clipped version of the text. I think the better UX here would be to prevent them from typing in the long text.

I'm going to merge this for now and can address UX improvement in follow up.

[benjreinhart]

Thank you for this 🙏🏻

[Aswanth-c]

This allows users to type in a long heading but then it disappears on blur with a clipped version of the text. I think the better UX here would be to prevent them from typing in the long text.

I'm going to merge this for now and can address UX improvement in follow up.

This allows users to type in a long heading but then it disappears on blur with a clipped version of the text. I think the better UX here would be to prevent them from typing in the long text.

I'm going to merge this for now and can address UX improvement in follow up.

The issue where users can type a long heading but it gets clipped on blur is occurring because the latest changes to the TitleCellUpdateAttrsSchema weren’t reflected due to the shared package not being built. In our monorepo setup, the changes only take effect after the package has been properly built.

But I saw you did a great job on ux wise so this doesn't matter

[benjreinhart]

In our monorepo setup, the changes only take effect after the package has been properly built.

Yes I noticed that as well. I thought we had fixed this in #201 but it looks like we still need to build. FWIW you can run pnpm run build in repo root when developing.

[Aswanth-c]

In our monorepo setup, the changes only take effect after the package has been properly built.

Yes I noticed that as well. I thought we had fixed this in #201 but it looks like we still need to build. FWIW you can run pnpm run build in repo root when developing.

This branch was behind the turbo branch. I think running turbo dev on a newer versions fix this issue