This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: format/index perf, buffered reads, reflection removal #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracen
force-pushed
the
index-performance-improvements
branch
from
1ccc0fa
to
5598068
Compare
Large performance increase by buffering reads. There were a few instances where binary.Read() would end up using reflection on &plumbing.Hash, rather than treating it as a byte slice. This has now been resolved. Signed-off-by: Arran Walker <arran.walker@fiveturns.org>
mcuadros
reviewed
Apr 22, 2019
saracen
force-pushed
the
index-performance-improvements
branch
from
a9fbf5b
to
7dcc710
Compare
jfontan
approved these changes
Apr 22, 2019
saracen
force-pushed
the
index-performance-improvements
branch
from
7dcc710
to
262179b
Compare
Signed-off-by: Arran Walker <arran.walker@fiveturns.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large performance increase by buffering reads.
There were a few instances where binary.Read() would end up using reflection on &plumbing.Hash, rather than treating it as a byte slice. This has now been resolved.