This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: packfile/scanner, add option to skip calculating checksum #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipnavara
changed the title
…use the option at place where the checksum is ignored anyway Signed-off-by: Filip Navara <navara@emclient.com>
filipnavara
changed the title
|
Seems that #1124 addresses my performance concerns in a better way where the CRC calculation is fast enough to be ignored. Feel free to close this PR in favor of that one. |
|
The overhead of calculating the CRC may be small enough to be negligable now. I'll rework this PR and test it on my use case to see whether there's still any point in pursuing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and use the option at places where the checksum is ignored anyway.