Add Picasso#rememberPainter extension function under new :picasso-compose module #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamepro65
force-pushed
the
cdrury/composeUI
branch
from
cea2f21
to
9e69e9e
Compare
gamepro65
force-pushed
the
cdrury/composeUI
branch
from
9e69e9e
to
780073d
Compare
jrodbx
approved these changes
May 25, 2022
picasso-compose/gradle.properties
Outdated
| @@ -0,0 +1,4 @@ | |||
| POM_ARTIFACT_ID=picasso-compose | |||
| POM_NAME=Picasso Compose | |||
| POM_DESCRIPTION=A Compose UI plugin for Picasso. | |||
There was a problem hiding this comment.
Suggested change
| POM_DESCRIPTION=A Compose UI plugin for Picasso. | |
| POM_DESCRIPTION=Compose UI support for Picasso. |
jrodbx
reviewed
May 25, 2022
build.gradle
Outdated
| @@ -28,6 +28,11 @@ buildscript { | |||
| truth: 'com.google.truth:truth:1.1.3', | |||
| robolectric: 'org.robolectric:robolectric:4.6.1', | |||
| mockito: 'org.mockito:mockito-core:3.0.0', | |||
| appCompat: 'androidx.appcompat:appcompat:1.3.1', | |||
jrodbx
reviewed
May 25, 2022
build.gradle
Outdated
| appCompat: 'androidx.appcompat:appcompat:1.3.1', | ||
| drawablePainter: 'com.google.accompanist:accompanist-drawablepainter:0.19.0', | ||
| composeUi: 'androidx.compose.ui:ui:1.1.1', | ||
| composeUiTooling: 'androidx.compose.ui:ui-tooling:1.1.1', |
gamepro65
force-pushed
the
cdrury/composeUI
branch
from
780073d
to
584f31f
Compare
gamepro65
force-pushed
the
cdrury/composeUI
branch
from
584f31f
to
01cfad9
Compare
|
Thanks for providing this—this is great! Is there an issue we can follow to see when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new :picasso-compose module which exposes a Picasso#rememberPainter function for use with Compose UI. To achieve this Picasso exposes a new .into(DrawableTarget) that way we can provide a PicassoDrawable to the Painter which will keep the API consistent with how we load .into(ImageView).
picasso-compose-ui.mp4