Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Kolmogorov test #228

Closed
Tracked by #229
filippopericoli opened this issue Aug 8, 2022 · 0 comments · Fixed by #230
Closed
Tracked by #229

Adding the Kolmogorov test #228

filippopericoli opened this issue Aug 8, 2022 · 0 comments · Fixed by #230
Assignees
Labels
enhancement New feature or request

Comments

@filippopericoli
Copy link

Is your feature request related to a problem? Please describe.
I find your package very interesting, I would just use another R function to make it a bit more complete, even though it is not a big proposal change min

Describe the solution you'd like
I would like to add the Kolmogorv-Smiirnov test already available in R to get a confirmation that the proposal distribution is a good candidate for data at hand. The result of the test would help in understanding that not only the selected distribution is the best one in relative terms, but also that it does a good job in approximating the data at disposal

Describe alternatives you've considered
The test can be added as described here:
https://www.geeksforgeeks.org/kolmogorov-smirnov-test-in-r-programming/#:~:text=The%20Kolmogorov%2DSmirnov%20Test%20is,two%2Dsample%20K%2DS%20test).
One has to use the command ks(x,y,) where x and y are the 2 distributions. The only trick is that one has to random from the proposal distribution and from the data a sample or repeated samples.

Additional context
I don't have nothing else to add. Good luck. I am happy to share ideas and projects.

@spsanderson spsanderson self-assigned this Aug 9, 2022
@spsanderson spsanderson added the enhancement New feature or request label Aug 9, 2022
@spsanderson spsanderson added this to the TidyDensity 1.2.2 milestone Aug 9, 2022
spsanderson added a commit that referenced this issue Aug 9, 2022
Fixes #228
Fixes #227
@spsanderson spsanderson mentioned this issue Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants