Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks if the generated nonce is valid. #124

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Checks if the generated nonce is valid. #124

merged 2 commits into from
Oct 10, 2022

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented Oct 10, 2022

Throws if the generated nonce has less then 8 characters and is null, undefined or an empty string.

@w4ll3 w4ll3 requested review from sbihel and skgbafa October 10, 2022 02:18
sbihel
sbihel reviewed Oct 10, 2022
View reviewed changes
packages/siwe/lib/utils.ts Outdated Show resolved Hide resolved
@w4ll3 w4ll3 requested a review from sbihel October 10, 2022 16:29
@w4ll3 w4ll3 merged commit 763c662 into main Oct 10, 2022
@w4ll3 w4ll3 deleted the feat/nonce-generation-validation branch October 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

@skgbafa skgbafa Awaiting requested review from skgbafa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w4ll3 @sbihel