LdapAuthoritiesPopulator should be postProcessed #9276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable customizations, just like other objects in the LdapAuthenticationProviderConfigurer class
|
Note: I ran into this issue this PR and used a temporary work around for my local build |
jzheaux
requested changes
Dec 11, 2020
There was a problem hiding this comment.
Thanks for the PR, @fhanik! Will you please update the copyright on these classes so that the end date is 2020?
There is a checkstyle error in the build. I realize that locally you might not have gotten that given the 401 issue you were experiencing earlier in the build, but I think if you try again, you'll see that error now.
|
@fhanik, are you able to make the requested changes? |
jzheaux
added
in: ldap
jzheaux
added a commit
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can set an
LdapAuthoritiesPopulatorand override the default one. However, the current implementation doesn't allow us to create a delegate to the default populator, because it isn't post processedThis simple fix will allow an easier customization of the
LdapAuthoritiesPopulator