Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix in Customizing OpenSAML’s AuthnRequest Instance section #10463

Closed
wants to merge 1 commit into from

Conversation

nor-ek
Copy link
Contributor

@nor-ek nor-ek commented Nov 1, 2021

According to the wrong example in the Customizing OpenSAML’s AuthnRequest Instance section I've fixed it.
What is done:

  • replace Converter<MySaml2AuthenticationRequestContext, AuthnRequest> by Converter<Saml2AuthenticationRequestContext, AuthnRequest>
  • replace MySaml2AuthenticationRequestContext by Saml2AuthenticationRequestContext in AuthnRequestConverter. (Not sure if its correct example)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 1, 2021
@jzheaux jzheaux self-assigned this Nov 2, 2021
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 2, 2021
@jzheaux jzheaux added this to the 5.6.0 milestone Nov 2, 2021
@nor-ek nor-ek changed the title Gh 10364 Documentation fix in Customizing OpenSAML’s AuthnRequest Instance section Nov 4, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Nov 5, 2021

Thanks, @nor-ek!

Will you please adjust your commit to include the ticket in the message instead of the title, like so?

Commit Title

Closes gh-10364

Also, you might consider squashing your commits as this will simplify backporting.

…ce documentation section

spring-projectsgh-10364 use Converter<Saml2AuthenticationRequestContext, AuthnRequest> instead of Converter<MySaml2AuthenticationRequestContext, AuthnRequest>
@nor-ek
Copy link
Contributor Author

nor-ek commented Nov 5, 2021

@jzheaux should be better.

@rwinch rwinch modified the milestones: 5.6.0, 5.7.0-M1 Nov 12, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Nov 18, 2021

Thanks @nor-ek. This is merged via 9316241 along with a polish of 2dac210

@jzheaux jzheaux closed this Nov 18, 2021
@jzheaux jzheaux modified the milestones: 5.7.0-M1, 6.0.0-M1 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants