Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CsrfFilter Accesses Session on Every Request #11456

Closed
2 tasks done
Tracked by #6125
rwinch opened this issue Jul 1, 2022 · 0 comments
Closed
2 tasks done
Tracked by #6125

CsrfFilter Accesses Session on Every Request #11456

rwinch opened this issue Jul 1, 2022 · 0 comments
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.8.0-M3

Comments

@rwinch
Copy link
Member

rwinch commented Jul 1, 2022 •
edited
Loading 

java.lang.RuntimeException: getSession(false)
	at example.SessionAccessedFilter$1.getSession(SessionAccessedFilter.java:25)
	at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:244)
	at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:244)
	at org.springframework.security.web.csrf.HttpSessionCsrfTokenRepository.loadToken(HttpSessionCsrfTokenRepository.java:65)
	at org.springframework.security.web.csrf.LazyCsrfTokenRepository.loadToken(LazyCsrfTokenRepository.java:80)
	at org.springframework.security.web.csrf.CsrfFilter.doFilterInternal(CsrfFilter.java:104)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:351)
@rwinch rwinch mentioned this issue Jul 1, 2022
Closed
7 tasks
@rwinch rwinch added this to the 5.8.x milestone Jul 1, 2022
@rwinch rwinch self-assigned this Jul 1, 2022
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Jul 1, 2022
@rwinch rwinch modified the milestones: 5.8.x, 5.8.0-M2, 5.8.0-M3 Aug 11, 2022
rwinch added a commit that referenced this issue Aug 16, 2022
@rwinch
Defer CsrfFilter Session Access
c1a6cea 
Closes gh-11456
@rwinch rwinch closed this as completed in 5cf42b1 Aug 16, 2022
sjohnr added a commit to sjohnr/spring-security that referenced this issue Sep 2, 2022
@sjohnr
Add new interfaces for CSRF request processing
186601e 
Issue spring-projectsgh-4001
Issue spring-projectsgh-11456
@sjohnr sjohnr mentioned this issue Sep 2, 2022
Merged
sjohnr added a commit that referenced this issue Sep 6, 2022
@sjohnr
Add new interfaces for CSRF request processing
86fbb8d 
Issue gh-4001
Issue gh-11456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
5.8.0-M3
Development

No branches or pull requests
1 participant
@rwinch