Add support for AUTO_PRODUCE schema #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for producing raw JSON or Avro payloads with AUTO_SCHEMA.
onobc
commented
Feb 11, 2024
| @@ -14,7 +14,7 @@ | |||
| :spring-cloud-stream-docs: https://docs.spring.io/spring-cloud-stream/docs/{spring-cloud-stream-version}/reference/html/ | |||
| :spring-cloud-function: https://spring.io/projects/spring-cloud-function | |||
|
|
|||
| :apache-pulsar-docs: https://pulsar.apache.org/docs/3.1.x | |||
| :apache-pulsar-docs: https://pulsar.apache.org/docs/3.2.x | |||
There was a problem hiding this comment.
[UNRELATED] Bump in docs to current version
onobc
commented
Feb 11, 2024
| @@ -193,7 +197,8 @@ static class ProducerCacheKey<T> { | |||
| Assert.notNull(schema, () -> "'schema' must be non-null"); | |||
| Assert.notNull(topic, () -> "'topic' must be non-null"); | |||
| this.schema = schema; | |||
| this.schemaHash = SchemaHash.of(this.schema); | |||
| this.schemaHash = (schema instanceof AutoProduceBytesSchema) ? AUTO_PRODUCE_SCHEMA_HASH | |||
There was a problem hiding this comment.
This is necessary as any call to AutoProduceSchema.getSchemaInfo() will throw RuntimeException on the client until after something has been sent and validated w/ the target topic (i.e a schema is initialized on it). In our case, we don't care about schema info, the producer can be used for any byte[] messages that the user wants to be validated against the target topic schema and this cache key will do that.
onobc
commented
Feb 11, 2024
| @@ -74,7 +75,7 @@ void cleanupFromTests() { | |||
| } | |||
|
|
|||
| @Test | |||
| void createProducerMultipleCalls() throws PulsarClientException { | |||
There was a problem hiding this comment.
[UNRELATED] Leftover from removal of checked exception in Spring Pulsar APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for producing raw JSON or Avro payloads with AUTO_SCHEMA.