Fix processCreationForm and processUpdateForm in OwnerController #1544 #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omelet3032 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@omelet3032 Thank you for signing the Contributor License Agreement! |
|
@omelet3032 Can you link this PR to issue #1544 ? To do this, you just need to add the following to the end of the PR description: fix #1544 |
dsyer
requested changes
Jul 6, 2024
| if (result.hasErrors()) { | ||
| redirectAttributes.addFlashAttribute("error", "There was an error in creating the owner."); | ||
| model.addAttribute("owner", owner); |
There was a problem hiding this comment.
This is unnecessary (it's already in the model).
|
Closing (timeout). It was a trivial change and I'll merge it if anyone wants to resubmit a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1544