Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OracleSQL #1410

Closed

Conversation

radughiorma
Copy link

Added support to use the oracle database.

@snicoll
Copy link
Member

snicoll commented May 26, 2024

Thanks for the PR but the docker compose makes it so that the database is provided so there's no need to have two of them.

@snicoll snicoll closed this May 26, 2024
@snicoll
Copy link
Member

snicoll commented May 26, 2024

Sorry, I hadn't noticed we already do this for mysql/postgresql.

@dsyer is that really expected?

@snicoll snicoll reopened this May 26, 2024
@dsyer
Copy link
Member

dsyer commented May 26, 2024

We always (before docker) had Postgres and MySql, so we just continued the tradition I think. I’m not sure I’m happy having every single database in the universe (just because the jar files mount up and most people don’t use more than one). For my part I’m am OK with closing this.

@dsyer dsyer closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants