-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring.modulith.events.jdbc.schema
to allow defining which database schema the event_publication
table resides in
#685
Comments
What is the expected behavior when configuring the schema property for a MySQL database? |
…to allow defining the database schema for the event_publication table.
Thanks for the contribution. I will have a look at your PR. Assigning you in the meantime so that nobody else accidentally starts working on it. |
…ng the database schema for the event_publication table.
Disable schema support for MySQL as it doesn't know about schemas per database. General polishing.
I've applied the PR but actively reject setting the schema for MySQL as it doesn't know about schemas per database. The test for the functionality were flaky and working accidentally if the “no schema configured” ones ran first, as Testcontainers ignores the database name for hostless DB configuration and sets the DB name to Thanks for the contribution! 🙇 |
Disable schema support for MySQL as it doesn't know about schemas per database. General polishing.
This was exactly the doubtful part I raised in my question above 😅. In MySQL, the 'schema' refers to the database itself.. Thank you for applying the PR and for the feedback. |
As described in GH-683, it might be desirable to define the schema for the
event_publication
table explicitly. We could introduce aspring.modulith.events.jdbc.schema
property to allow easy configuration of that.Required steps
src/main/resources/META-INF/spring-configuration-metadata.json
JbcEventPublicationRepository
src/docs/antora/mopdules/ROOT/pages/appendix.adoc
)JdbcConfigurationProperties
and use that from the repository implementation. This would allow us to get rid of the manually maintainedspring-configuration-metadata.json
in favor of using the configuration class processor to create the metadata automatically.The text was updated successfully, but these errors were encountered: