Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module-internal dependencies rejected if allowed dependencies defined explicitly #661

Closed
odrotbohm opened this issue Jun 18, 2024 · 0 comments
Closed

Module-internal dependencies rejected if allowed dependencies defined explicitly #661

odrotbohm opened this issue Jun 18, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core module meta model type: bug Something isn't working
Milestone
1.2.1

Comments

@odrotbohm
Copy link
Member

Back-port of GH-660.
@odrotbohm odrotbohm added in: core Core module meta model type: bug Something isn't working labels Jun 18, 2024
@odrotbohm odrotbohm added this to the 1.2.1 milestone Jun 18, 2024
@odrotbohm odrotbohm self-assigned this Jun 18, 2024
odrotbohm added a commit that referenced this issue Jun 18, 2024
@odrotbohm
GH-661 - Dependency checks now explicitly skip module-internal depend…
8d86615 
…encies.

As we process a type's entire type hierarchy for dependencies we might discover a foreign module's internal dependencies for modules that declare allowed dependencies explicitly. Explicitly declared dependencies so far solely verified the target being explicitly listed, which, for internal dependencies does not make sense. We now immediately start checking the source and target modules to be equivalent, in which case we can skip any further processing.
@odrotbohm odrotbohm mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core module meta model type: bug Something isn't working
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
1 participant
@odrotbohm