Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure the ApplicationModuleDetectionStrategy via a configuration property #656

Closed
odrotbohm opened this issue Jun 17, 2024 · 0 comments
Closed

Allow to configure the ApplicationModuleDetectionStrategy via a configuration property #656

odrotbohm opened this issue Jun 17, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core module meta model type: improvement Minor improvements
Milestone
1.2.1

Comments

@odrotbohm
Copy link
Member

Backport of GH-652.
@odrotbohm odrotbohm added in: core Core module meta model type: enhancement Major enhanvements, new features labels Jun 17, 2024
@odrotbohm odrotbohm added this to the 1.2.1 milestone Jun 17, 2024
@odrotbohm odrotbohm self-assigned this Jun 17, 2024
@odrotbohm odrotbohm added type: improvement Minor improvements and removed type: enhancement Major enhanvements, new features labels Jun 17, 2024
odrotbohm added a commit that referenced this issue Jun 17, 2024
@odrotbohm
GH-656 - Allow to configure the ApplicationModuleDetectionStrategy vi…
702fac5 
…a a configuration property.

We now expose a configuration property spring.modulith.detection-strategy that can take either of the two prepared values "direct-sub-packages" (default) or "explicitly-annotated", or a fully qualified class name of the strategy to use.

Removed ApplicationModuleStrategies enum to avoid exposing the enum values as additional implementations. Those are now held as inline lambda expression in the factory methods on ApplicationModuleStrategy. Extracted the lookup of the strategy to use into ApplicationModuleDetectionStrategyLookup for easier testability.
odrotbohm added a commit that referenced this issue Jun 17, 2024
@odrotbohm
GH-656 - Polishing.
4823bba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core module meta model type: improvement Minor improvements
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
1 participant
@odrotbohm