Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs build #782

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Docs build #782

merged 1 commit into from
Jul 12, 2023

Conversation

rwinch
Copy link
Member

@rwinch rwinch commented Jul 6, 2023

No description provided.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rwinch! I've left some feedback inline. Most of it relates to wanting to make sure references to Spring Framework, Security, and LDAP are correct.

Note that if my comment about 6.0.x is correct, please change all the references that make sense. I didn't want to clutter the review with several of the same observation.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
antora-playbook.yml Outdated Show resolved Hide resolved
antora-playbook.yml Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
@rwinch
Copy link
Member Author

rwinch commented Jul 6, 2023

Thanks @jzheaux I've pushed changes to address your comments

@jzheaux jzheaux self-assigned this Jul 11, 2023
@jzheaux jzheaux merged commit 60529e6 into spring-projects:docs-build Jul 12, 2023
@jzheaux jzheaux added this to the 3.2.0-M1 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants