Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for KafkaListenerContainerFactory #2292

Closed
sergey-morenets opened this issue Jun 2, 2022 · 1 comment
Closed

Documentation update for KafkaListenerContainerFactory #2292

sergey-morenets opened this issue Jun 2, 2022 · 1 comment

Comments

@sergey-morenets
Copy link

In what version(s) of Spring for Apache Kafka are you seeing this issue?

2.8.6(latest)

Describe the bug

The latest Spring Kafka documentation contains outdated information about KafkaListenerContainerFactory (two generic types):
https://docs.spring.io/spring-kafka/reference/html/

@Bean
public KafkaListenerContainerFactory<?, ?> kafkaJsonListenerContainerFactory() {
    ConcurrentKafkaListenerContainerFactory<Integer, String> factory =
        new ConcurrentKafkaListenerContainerFactory<>();
    factory.setConsumerFactory(consumerFactory());
    factory.setMessageConverter(new JsonMessageConverter());
    return factory;
}

But the current version of KafkaListenerContainerFactory has only one generic type:
https://github.com/spring-projects/spring-kafka/blob/main/spring-kafka/src/main/java/org/springframework/kafka/config/KafkaListenerContainerFactory.java

public interface KafkaListenerContainerFactory<C extends MessageListenerContainer> {

To Reproduce

Expected behavior

Spring Kafka documentation should use only one generic type for KafkaListenerContainerFactory.

@garyrussell
Copy link
Contributor

Thanks; cherry-picked to all supported branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants