Fix ImapIdleChA for scheduling race condition #8670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IMAP IDLE is long-lived process and can be blocked waiting for any reply from the server. This way it is not suited to be used in a `TaskScheduler` especially when it has only one thread in its pool in Spring Boot by default. Another concurrent scheduled task is exactly an `ImapMailReceiver.IdleCanceller`. With a single thread in a `TaskScheduler` pool it cannot be reached therefore we never cancel and IDLE task and cannot react to the connection loss properly * Rework the `ImapIdleChannelAdapter` logic to use a regular `Executor` and `while()` loop with a `Thread.sleep()` when we lose connection * Clean up the `ImapMailReceiverTests` from `TaskScheduler` not used anymore. * Expose new `taskExecutor` option in the `ImapIdleChannelAdapterSpec` for Java DSL * Enable `ImapMailReceiverTests.testIdleWithMessageMapping()` with an attempt to see if this fix covers an unclear problem exposed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IMAP IDLE is long-lived process and can be blocked waiting for any reply from the server.
This way it is not suited to be used in a
TaskSchedulerespecially when it has only one thread in its pool in Spring Boot by default. Another concurrent scheduled task is exactly anImapMailReceiver.IdleCanceller. With a single thread in aTaskSchedulerpool it cannot be reached therefore we never cancel and IDLE task and cannot react to the connection loss properlyImapIdleChannelAdapterlogic to use a regularExecutorandwhile()loop with aThread.sleep()when we lose connectionImapMailReceiverTestsfromTaskSchedulernot used anymore.taskExecutoroption in theImapIdleChannelAdapterSpecfor Java DSLImapMailReceiverTests.testIdleWithMessageMapping()with an attempt to see if this fix covers an unclear problem exposed before