Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerWebSocketContainer can't stop #3744

Closed
Sorieee opened this issue Mar 9, 2022 · 0 comments
Closed

ServerWebSocketContainer can't stop #3744

Sorieee opened this issue Mar 9, 2022 · 0 comments
Labels
in: websocket type: bug
Milestone
6.0 M2

Comments

@Sorieee
Copy link
Contributor

Sorieee commented Mar 9, 2022

In what version(s) of Spring Integration are you seeing this issue?

main branch

Describe the bug
Should stop handshakeHandler in ServerWebSocketContainer.stop() rather than start.
image

To Reproduce

Expected behavior

Sample

None
@Sorieee Sorieee added status: waiting-for-triage The issue need to be evaluated and its future decided type: bug labels Mar 9, 2022
Sorieee added a commit to Sorieee/spring-integration that referenced this issue Mar 9, 2022
@Sorieee
Fixes spring-projects#3744
95e680f 
* Fix `ServerWebSocketContainer` can't stop
@artembilan artembilan added this to the 6.0 M2 milestone Mar 9, 2022
@artembilan artembilan added backport 5.5.x in: websocket and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Mar 9, 2022
artembilan pushed a commit that referenced this issue Mar 9, 2022
@Sorieee @artembilan
GH-3744: Fix ServerWebSocketContainer.stop()
bbc4e1e 
Fixes #3744

The `ServerWebSocketContainer.stop()` accidentally calls `this.handshakeHandler.start()`

**Cherry-pick to `5.5.x`**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: websocket type: bug
Projects
None yet
Milestone
6.0 M2
Development

No branches or pull requests
2 participants
@artembilan @Sorieee