Allow custom observation convention for RestClient
#31325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to use a custom `ObservationConvention` in the `DefaultRestClient`, and to set it through the `RestClient.Builder`.
spring-projects-issues
added
the
status: waiting-for-triage
|
Custom observation conventions can be configured on the registry itself directly. While this change aligns more with the other clients there are other instrumentations in Framework that don't offer a configuration option on the instrumented directly. I'll discuss that with the observability team to get their opinion. |
bclozel
added
type: enhancement
|
Thanks @hpoettker , we've merged your contribution. We're mostly doing this for consistency with other HTTP clients but we don't intend to provide this option for all instrumentations as they can be configured with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the possibility to use a custom
ObservationConventionin theRestClient, and to set it through its builder.Observability has been added to
RestClientin #31114 based on the same infrastructure used byRestTemplate. Setting a customObservationConventionis supported with bothRestTemplateandWebClient, and I was surprised thatRestClientcurrently does not support it.