Add Criteria infix functions for maxDistance and minDistance
#3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sangyongchoi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@sangyongchoi Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @sangyongchoi for taking the time to report this and craft a fix. |
mp911de
changed the title
maxDistance and minDistance
mp911de
added
type: enhancement
mp911de
pushed a commit
that referenced
this pull request
Aug 25, 2021
mp911de
added a commit
that referenced
this pull request
Aug 25, 2021
Update since version. Reformat code. See: #3761.
mp911de
added a commit
that referenced
this pull request
Aug 25, 2021
Update since version. Reformat code. See: #3761.
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Criteria infix func
Because to use minDistance and maxDistance, near and nearSphere must exist.
But currently using infix fun to use minDistance, maxDistance throws an error.
Because we're adding it to the new Criteria.
A repository where you can check for errors
I think good if criteria with Near Sphere and NearSphere added min Distance and Max Distance could be easily added. so I will send you a PR.