Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish #42268

Closed
wants to merge 1 commit into from
Closed

Polish #42268

wants to merge 1 commit into from

Conversation

arefbehboudi
Copy link
Contributor

  • Removed @SuppressWarnings as it was no longer needed.
  • Used pattern matching.
  • Replace the while loop with string repeat

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 11, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 11, 2024
@philwebb philwebb added this to the 3.4.x milestone Sep 11, 2024
@mhalbritter mhalbritter self-assigned this Sep 12, 2024
mhalbritter pushed a commit that referenced this pull request Sep 12, 2024
@arefbehboudi @mhalbritter
Polish
bf1ef30 
See gh-42268
@mhalbritter
Copy link
Contributor

Thanks!

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-M3 Sep 12, 2024
@arefbehboudi
Copy link
Contributor Author

thank you @mhalbritter , Can I ask why my pull request build is getting errors?

@mhalbritter
Copy link
Contributor

On the CI, you mean? There's something wrong in the infrastructure I think.

@arefbehboudi
Copy link
Contributor Author

Thank you, so the issue is not with my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: task A general task
Projects
None yet
Milestone
3.4.0-M3
Development

Successfully merging this pull request may close these issues.
4 participants
@arefbehboudi @mhalbritter @philwebb @spring-projects-issues