Polish #42192
Closed
Polish #42192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arefbehboudi
commented
Sep 9, 2024
arefbehboudi
commented
- Removed @SuppressWarnings as it was no longer needed.
- Used pattern matching.
- Updated documentation.
- Replaced class with record.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Sep 9, 2024
...a/org/springframework/boot/rsocket/context/RSocketPortInfoApplicationContextInitializer.java
Outdated
Show resolved
Hide resolved
...ng-boot-project/spring-boot/src/main/java/org/springframework/boot/json/JsonValueWriter.java
Outdated
Show resolved
Hide resolved
...-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DataSourceBuilder.java
Outdated
Show resolved
Hide resolved
|
@wilkinsona Thanks for the review. I've updated the code based on your feedback. Please check it again when you can. |
snicoll
added
type: task
snicoll
added a commit
that referenced
this pull request
Sep 10, 2024
|
@arefbehboudi thanks for the contribution. It wasn't building as the formatting was no longer correct. FTR you could have seen that locally by building the module, something like: I've polished things in ece5c6f |
|
@snicoll Thanks for pointing that out! I'll make sure to run the build locally using the provided command to catch any formatting issues in the future. Thanks again for the guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.