Provide a configuration property for endpoints' CORS origin patterns #24608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedivo Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@pedivo Thank you for signing the Contributor License Agreement! |
philwebb
added
type: enhancement
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
CorsConfigurationis configured to allow credentials you cannot use wildcards on theallowedOriginsattribute.The
CorsConfigurationitself asks to use theallowedOriginPatternswhen do you want to use wildcards and allow credentials at the same time.However, there isn't a way to configure the
allowedOriginPatternson theCorsEndpointProperties.I've just added the possibility to configure the
allowedOriginPatternson theCorsEndpointProperties.