Remove deprecated 2.2 code #19699
Closed
Remove deprecated 2.2 code #19699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
scottfrederick
force-pushed
the
gh-19597
branch
from
5e13563
to
c6aac0b
Compare
mbhave
added
type: task
scottfrederick
force-pushed
the
gh-19597
branch
from
c6aac0b
to
39cbe2d
Compare
snicoll
reviewed
Jan 14, 2020
There was a problem hiding this comment.
Looks good to me. I've added a few comments. The copyright of each changed source files should be updated as well.
This is much larger than I thought it would be and I am wondering if we shouldn't split that in separate commits. One for the health indicator certainly would help make it more manageable.
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/LogFile.java
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/health/HealthEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
scottfrederick
force-pushed
the
gh-19597
branch
from
39cbe2d
to
c628cd6
Compare
|
I've resolved the two comments above, updated copyrights, and split the changes into several commits aligned to a few themes. |
|
Added another commit to remove Joda-Time auto-configuration. |
snicoll
pushed a commit
that referenced
this pull request
Jan 16, 2020
snicoll
added a commit
that referenced
this pull request
Jan 16, 2020
snicoll
pushed a commit
that referenced
this pull request
Jan 16, 2020
snicoll
pushed a commit
that referenced
this pull request
Jan 16, 2020
snicoll
pushed a commit
that referenced
this pull request
Jan 16, 2020
snicoll
pushed a commit
that referenced
this pull request
Jan 16, 2020
snicoll
added a commit
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #19597
This PR includes all deprecations that were explicitly marked
since 2.2. There are other deprecations that are not marked with asincethat need to be evaluated for removal in 2.3.