Rework an observation for Rabbit Binder #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
force-pushed
the
multi_binder_observation
branch
from
726cfcf
to
f48e4a1
Compare
The observation propagation doesn't work in multi-binder configuration * Remove `ObservationAutoConfiguration` since it is not visible in case of multi-binder configuration * Instead move `setObservationEnabled` flag setting to the `RabbitMessageChannelBinder` * Add `io.micrometer.observation.ObservationRegistry` into `shared.beans` to make it visible for binder-specific application context * Add `RabbitMultiBinderObservationTests` integration test where Rabbit Binder is in multi-binder environment As a side effect this fixes an observation propagation for Kafka binder as well in the multi-binder environment. Its configuration is OK, but an `ObservationRegistry` must make it visible for the binder-specific application context. See the mentioned `shared.beans` Related to spring-cloud#2901 Also see spring-cloud#2902 for possible evolution
artembilan
force-pushed
the
multi_binder_observation
branch
from
f48e4a1
to
fd00668
Compare
|
@artembilan Looks good. One small comment - some classes are missing copyright updates to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observation propagation doesn't work in multi-binder configuration
ObservationAutoConfigurationsince it is not visible in case of multi-binder configurationsetObservationEnabledflag setting to theRabbitMessageChannelBinderio.micrometer.observation.ObservationRegistryintoshared.beansto make it visible for binder-specific application contextRabbitMultiBinderObservationTestsintegration test where Rabbit Binder is in multi-binder environmentAs a side effect this fixes an observation propagation for Kafka binder as well in the multi-binder environment. Its configuration is OK, but an
ObservationRegistrymust make it visible for the binder-specific application context. See the mentionedshared.beansRelated to #2901 Also see #2902 for possible evolution