PAPP-3712 - accomodate case where JIRA is behind proxy #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctonderski-splunk
force-pushed
the
mctonderski/PAPP-33712
branch
from
502d2d0
to
a53c979
Compare
mctonderski-splunk
force-pushed
the
mctonderski/PAPP-33712
branch
from
2befb62
to
26e353a
Compare
ivellios
previously approved these changes
Sep 17, 2024
| @@ -357,6 +357,8 @@ VARIABLE | REQUIRED | TYPE | DESCRIPTION | |||
| **max_tickets** | optional | numeric | Maximum tickets (issues) for scheduled polling | |||
| **custom_fields** | optional | string | JSON formatted list of names of custom fields (case-sensitive) to be ingested | |||
| **timezone** | required | timezone | Jira instance timezone (used for timezone conversions for querying in ingestion). Refer to README | |||
| **custom_field_enumeration** | optional | boolean | Disable Field Enumeration | |||
There was a problem hiding this comment.
"Disable Field Enumeration" as a description for the custom_field_enumeration property is a bit confusing. Can't we just have "Custom Field Enumeration" or even something that is more obvious to end users?
| @@ -357,6 +357,8 @@ VARIABLE | REQUIRED | TYPE | DESCRIPTION | |||
| **max_tickets** | optional | numeric | Maximum tickets (issues) for scheduled polling | |||
| **custom_fields** | optional | string | JSON formatted list of names of custom fields (case-sensitive) to be ingested | |||
| **timezone** | required | timezone | Jira instance timezone (used for timezone conversions for querying in ingestion). Refer to README | |||
| **custom_field_enumeration** | optional | boolean | Disable Field Enumeration | |||
| **internal_address_behind_proxy** | optional | string | URL address of JIRA service behind proxy (To be replaced in order to properly access) | |||
There was a problem hiding this comment.
How about changing the description to: URL address of the JIRA service behind the proxy (to be replaced for proper access)
| def _get_custom_fields_for_issue(self, issue_id, action_result): | ||
| @staticmethod | ||
| def _replace_internal_with_proxy_url(value, internal_address, proxy_address): | ||
| # If the value is a string and contains the internal address, replace it with the proxy address |
There was a problem hiding this comment.
This comment is not needed as the next line explains what happens
mctonderski-splunk
force-pushed
the
mctonderski/PAPP-33712
branch
from
d2ac7b0
to
6d15571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>nextbranch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md.manual_readme_content.mdall methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md.the Vault API.
nosemgrep?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!