-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAPP-33470] Bugfix: Recurrent multipart parsing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mposluszny-splunk
force-pushed
the
mposluszny/PAPP-33470
branch
from
March 28, 2024 13:20
9bed388
to
0cd5b61
Compare
bbielinski-splunk
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have left some suggestions to address.
bbielinski-splunk
approved these changes
Apr 3, 2024
bb-splunk
requested changes
Apr 3, 2024
bb-splunk
reviewed
Apr 3, 2024
bb-splunk
approved these changes
Apr 3, 2024
ivellios
approved these changes
Apr 3, 2024
mposluszny-splunk
added a commit
that referenced
this pull request
Apr 8, 2024
* [PAPP-33470] Bugfix: Recurrent multipart parsing (#20) * recurrent multipart parsing * Update README.md * linting fix * fix for "in_attachment" traversal * ph_status -> ret_val * applying suggestions --------- Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar> * Bumped up the version of googleworkspaceforgmail from 2.5.2 to 2.5.3 * proper release notes, function naming convention (#24) * Release notes for version 2.5.3 --------- Co-authored-by: mposluszny-splunk <150343546+mposluszny-splunk@users.noreply.github.com> Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar> Co-authored-by: root <root@splunksoar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!