Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAPP-33472: Updated certifi, urllib3 dependencies in order to use platform packages #19

Merged
merged 6 commits into from
Mar 28, 2024
Merged

PAPP-33472: Updated certifi, urllib3 dependencies in order to use platform packages #19

merged 6 commits into from
Mar 28, 2024

Conversation

achandya-crest
Copy link
Contributor

@achandya-crest achandya-crest commented Mar 21, 2024 •
edited by sodle-splunk
Loading

Fixes https://splunk.atlassian.net/browse/PAPP-33472

  • Remove the certifi and urllib dependencies, and use the ones built into the platform instead.
  • Regenerate the wheels directory to remove stale modules and fix the folder organization
  • Update pyparsing to 3.1.2 to fix vulnerabilities

Some checks are failing:

  • action[run_query_sender] is failing because the asset is in an unexpected state. This failure is unrelated to this change and can be ignored for now.
  • Polling is intermittently failing, we should investigate in a future ticket

@hardik-crest hardik-crest changed the title Updated certifi, urllib3 dependencies in order to use platform packages PAPP-31096, PAPP-30822, PAPP-33451 : Updated certifi, urllib3 dependencies in order to use platform packages Mar 27, 2024
@sodle-splunk sodle-splunk changed the title PAPP-31096, PAPP-30822, PAPP-33451 : Updated certifi, urllib3 dependencies in order to use platform packages PAPP-33472: Updated certifi, urllib3 dependencies in order to use platform packages Mar 27, 2024
@sodle-splunk sodle-splunk merged commit 87d2be3 into next Mar 28, 2024
7 of 9 checks passed
@sodle-splunk sodle-splunk deleted the update_modules branch March 28, 2024 14:51
This was referenced Mar 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexa-phantom alexa-phantom alexa-phantom approved these changes

@bbielinski-splunk bbielinski-splunk bbielinski-splunk approved these changes

Assignees
No one assigned
Labels
splunk-supported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@achandya-crest @alexa-phantom @bbielinski-splunk @splunk-soar-connectors-bot @sodle-splunk @hardik-crest