Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile friendly #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Mobile friendly #2

wants to merge 8 commits into from

Conversation

jmartin2939
Copy link

The changes made are to insure mobile friendliness. The formatting is essentially the same as it always has been, but a few changes have been made to insure it works on desktop and mobile:
commie
mobile-commie

Also kept the date in the footer, and made smaller adjustments- hopefully nothing you feel takes from the simplicity, I want to contribute not be intrusive :).

Tested on my server and all functionally seems intact.

Josh Martin and others added 8 commits January 6, 2016 11:41
new layout, and started adding list of pastes for private use
Formatting
added formatting to make the site mobile friendly. Removed previous
format changes
@clawoflight
Copy link
Contributor

Looks good to me.
However, you will probably want to cherry-pick the changes you kept and consolidate them into 2 commits (actual changes and readme update).

As it is, I'm not sure that @splitbrain will be happy merging 8 commits of which six only make and undo unneeded changes.

Thanks for doing this though, the mobile-friendly layout is a very welcome addition indeed!

@@ -69,11 +79,15 @@ li div.newcomment button {
}

#new textarea {
max-width: 79em;
max-width: 1000px;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? This switches from a 79 char width (which is a pretty common width for text) to an arbitrary pixel width depending on the font.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good reason for this one. I'm not sure why changed it, I'll change it back, it seems to work on mobile either (it should anyway.)

@clawoflight
Copy link
Contributor

any news on this?

@chang-zhao
Copy link

@jmartin2939 Josh, maybe you remove this pull request and make another, clean one, with only that line. It would be easy to accept then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants