Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic activity log #141

Merged
merged 5 commits into from
May 30, 2024
Merged

Add basic activity log #141

merged 5 commits into from
May 30, 2024

Conversation

dcbr
Copy link
Contributor

@dcbr dcbr commented Apr 14, 2024

This PR adds a basic implementation for an activity log in each group. Currently 4 types of activity are logged: updating the group settings and creating/updating/deleting an expense. If an active user is configured, the activity message includes the name of that active user. If #95 is approved, the "infinite scroll" feature can also be applied to this activity log (the implementation here is derived from the expense list).

image

Related issues are #15, #103 and #106.

@ChristopherJohnston
Copy link
Contributor

ChristopherJohnston commented Apr 14, 2024

nice! Might also be good to have the activity history for an individual expense at the bottom of the edit expense page.

Also a +1 on getting the #95 infinite scroll PR merged!

@justcallmelarry
Copy link
Contributor

Could be nice if the expenses were links to the expense in question!

@dcbr
Copy link
Contributor Author

dcbr commented Apr 17, 2024

@justcallmelarry They actually are linking to the expense, as long as it was not deleted in the meantime. This is denoted by the small arrows on the right (and a pointer cursor while hovering).

@justcallmelarry
Copy link
Contributor

@dcbr ah ok! nice! was not clear from the screenshot for me 😅 i was looking for the name of the group to be a link or similar

@justcallmelarry
Copy link
Contributor

This would also benefit from soft-deleting expenses, so that you can un-delete the expense from the log!

@dcbr
Copy link
Contributor Author

dcbr commented Apr 27, 2024

@justcallmelarry Yes indeed! However, I didn't want to introduce too many changes here, and just introduce a basic version that can later be extended. But I agree soft-deletion would be a nice feature for a follow-up PR :)

@sh3hz
Copy link

sh3hz commented May 19, 2024

Hi @scastiel, could you please review and merge this feature when you have a chance? This is definitely required for the app. Thanks!

@ChristopherJohnston
Copy link
Contributor

@scastiel I think the app will benefit greatly from this PR

@shynst
Copy link
Contributor

shynst commented May 28, 2024

Might also be good to have the activity history for an individual expense at the bottom of the edit expense page.

Great idea!

@scastiel scastiel merged commit e619c1a into spliit-app:main May 30, 2024
1 check passed
@scastiel
Copy link
Member

Thanks a lot @dcbr, amazing contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants