Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add games rating #52

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add games rating #52

wants to merge 6 commits into from

Conversation

easysugar
Copy link
Collaborator

I didn't find official ratings for the games, so I've added unofficial ratings.
Example:
image

@spilth
Copy link
Owner

spilth commented May 21, 2022

Where do these unofficial ratings come from?

@easysugar
Copy link
Collaborator Author

easysugar commented May 21, 2022

@spilth Almost the first link in the google https://whatnerd.com/every-jackbox-party-pack-ranked/. But it's possible to change ratings to something else.

@spilth
Copy link
Owner

spilth commented May 21, 2022

@easysugar I definitely appreciate the PRs you've been making. I think it would be good to start making Issues for functionality first so they can be discussed before folks start spending time on development.

For example, I don't know how valuable reversing the sort order is. I feel like default to alphabetical for names/packs and best to worst for ratings would be what folks want to see. That would mean a less complicated UX and less complicated code.

@easysugar
Copy link
Collaborator Author

Agree. But I think that ordering is a must for any sorting. So it should contain the reversing order to be logically completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants