Remove verb from API paths in favor of methods for v1 apis #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Xiaocao-Cxh
requested review from
lumjjb,
mrsabath,
mamy-CS and
maia-iyer
as code owners
maia-iyer
requested changes
Jul 24, 2024
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
changed the title
maia-iyer
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Removed verb from API paths Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Addressed pull request comments Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Fixed 1 last nit Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Removed verb from API paths Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Addressed pull request comments Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Fixed 1 last nit Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <65797697+Xiaocao-Cxh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.