Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Golang version and SPIRE libraries used #271 #272

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Conversation

maia-iyer
Copy link
Collaborator

@maia-iyer maia-iyer commented Jun 21, 2023

Closes #271 , Closes #273

  • Upgrades Golang version used by Github to v1.20 to accommodate newer SPIRE SDK
  • Updates Golang linter used by Github to v1.53
  • Upgrades SPIRE library to 1.6.4
  • Removes some code that had been dependent on SPIRE library for parsing the Tornjak config

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added dependencies Pull requests that update a dependency file backend Tornjak API (Backend) labels Jun 21, 2023
@maia-iyer maia-iyer added this to the 1.4.x milestone Jun 21, 2023
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer marked this pull request as ready for review June 22, 2023 15:25
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

version: v1.29
args: --timeout 5m
version: v1.53
args: --timeout 7m
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, does it take longer to complete the operation with 1.20?

@mrsabath mrsabath merged commit 9bcb327 into v1.4 Jun 27, 2023
6 checks passed
@mrsabath mrsabath deleted the update_golang branch June 27, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Github Golang version Upgrade used SPIRE libraries
2 participants