Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spire config requirement from backend #129 #266

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Remove spire config requirement from backend #129 #266

merged 3 commits into from
Jun 14, 2023

Conversation

maia-iyer
Copy link
Collaborator

Closes #129

@maia-iyer
Remove serverinfo requirement
aca604f 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Jun 14, 2023
@maia-iyer maia-iyer added this to the 1.3.x milestone Jun 14, 2023
@maia-iyer maia-iyer self-assigned this Jun 14, 2023
@maia-iyer maia-iyer removed the request for review from lumjjb June 14, 2023 19:05
@maia-iyer
Made clearer comments
53803f4 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Added documentation
ffa416f 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mamy-CS
mamy-CS approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mamy-CS mamy-CS merged commit 07514aa into v1.3 Jun 14, 2023
@maia-iyer maia-iyer deleted the rewrite_serverinfo branch June 14, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamy-CS mamy-CS mamy-CS approved these changes

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@maia-iyer maia-iyer

Labels
backend Tornjak API (Backend) go Pull requests that update Go code
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.

Remove SPIRE config file requirement
2 participants
@maia-iyer @mamy-CS