Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env path to frontend index file #255

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Add env path to frontend index file #255

merged 5 commits into from
Jun 8, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Jun 7, 2023 •
edited by mrsabath
Loading

Fixing the issue #256

@mamy-CS
add path
46e086f 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
adding branch to master build
c9fba96 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
changing path to /tmp
438be8a 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS
changing path to tmp
1c64e0b 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mrsabath
Copy link
Collaborator

mrsabath commented Jun 8, 2023

Switching to use ./build/tmp/env.js
This requires a read-write access to /usr/src/app/build/tmp directory.

Setup the frontend container with:

    volumeMounts:
      - mountPath: /usr/src/app/build/tmp
         name: env
   volumes:
     - emptyDir: {}
        name: env

mrsabath
mrsabath approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamy-CS
removing branch from master build
3aa6a1c 
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS merged commit ef9bb5b into main Jun 8, 2023
@mrsabath mrsabath changed the title Adding env path to frontend index file Add env path to frontend index file Jun 8, 2023
@mrsabath
Copy link
Collaborator

mrsabath commented Jun 8, 2023

This PR un-blocks the helm-chart PR spiffe/helm-charts#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsabath mrsabath mrsabath approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@maia-iyer maia-iyer Awaiting requested review from maia-iyer maia-iyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamy-CS @mrsabath