Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MUI to v5 #234

Merged
merged 22 commits into from
Jun 8, 2023
Merged

Migrate MUI to v5 #234

merged 22 commits into from
Jun 8, 2023

Conversation

Ve33y
Copy link
Contributor

@Ve33y Ve33y commented May 30, 2023

Should address #216

commit 2b3c2c1 might address some of #203

mrsabath and others added 2 commits May 23, 2023 14:59
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
* pagination

Signed-off-by: Aura6 <aura1391215@gmail.com>

* progress

Signed-off-by: Aura6 <aura1391215@gmail.com>

* progress

Signed-off-by: Aura6 <aura1391215@gmail.com>

* progress

Signed-off-by: Aura6 <aura1391215@gmail.com>

* 91% lines

Signed-off-by: Aura6 <aura1391215@gmail.com>

* comments

Signed-off-by: Aura6 <aura1391215@gmail.com>

* progress

Signed-off-by: Aura6 <aura1391215@gmail.com>

* ClusterCreate component testing + dynamic cluster adding to ClusterList

Signed-off-by: Aura6 <aura1391215@gmail.com>

* comments

Signed-off-by: Aura6 <aura1391215@gmail.com>

* key check

Signed-off-by: Aura6 <aura1391215@gmail.com>

* fixed typos

Signed-off-by: Aura6 <aura1391215@gmail.com>

* progress

Signed-off-by: Aura6 <aura1391215@gmail.com>

* update testing comp

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>

---------

Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Co-authored-by: Aura6 <aura1391215@gmail.com>
Co-authored-by: Mohammed Abdi <mohammma@usc.edu>
Ve33y added 10 commits May 30, 2023 16:35
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
@mamy-CS mamy-CS self-requested a review May 31, 2023 15:48
@mamy-CS mamy-CS added enhancement New feature or request frontend Tornjak UI (Frontend) javascript labels May 31, 2023
@mamy-CS mamy-CS added this to the 1.3.x milestone May 31, 2023
@Ve33y Ve33y marked this pull request as draft May 31, 2023 22:56
@Ve33y Ve33y marked this pull request as ready for review June 5, 2023 20:46
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Ve33y. Thank you for taking care of this and for your contribution as well. LGTM!

@mamy-CS mamy-CS merged commit 5a58559 into spiffe:v1.3 Jun 8, 2023
@mamy-CS mamy-CS mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Tornjak UI (Frontend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants