implement health check #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer
added
enhancement
mrsabath
reviewed
Apr 19, 2023
| ## 3.1. Agent API’s | ||
|
|
||
| ## 3.1. Tornjak API’s | ||
| ### - [Healthcheck](https://pkg.go.dev/google.golang.org/grpc/health/grpc_health_v1#HealthCheckRequest) |
There was a problem hiding this comment.
Why is this referencing health check from grpc instead of SPIRE?
There was a problem hiding this comment.
This is the health check tool that SPIRE uses - they import it directly in their implementation, so I think for us to access programmatically, this is what we have to do. Maybe I should put a note here?
mamy-CS
approved these changes
Apr 19, 2023
mamy-CS
pushed a commit
to mamy-CS/tornjak-public
that referenced
this pull request
Apr 20, 2023
* implemented health check Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * fixing lint check Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * reverting cmd file Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * nit Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * added debug server call Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adding documentation Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * attempting to clean lint Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * attempt to remove lint Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mamy-CS
added a commit
that referenced
this pull request
Apr 20, 2023
* parameterize ports in docker file Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> * implement health check (#161) * implemented health check Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * fixing lint check Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * reverting cmd file Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * nit Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * added debug server call Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adding documentation Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * attempting to clean lint Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * attempt to remove lint Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing more deadcode Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adding documentation Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> --------- Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net> Co-authored-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.