Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip process signaling if cmd field is empty #73

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Skip process signaling if cmd field is empty #73

merged 3 commits into from
Jun 18, 2023

Conversation

JU4N98
Copy link
Contributor

@JU4N98 JU4N98 commented Jun 15, 2023

Changes proposal:

  • If cmd field is not used or is empty, process signaling is going to be skipped.

@JU4N98
Skip process signaling if cmd field is empty or not defined.
6e14816 
Signed-off-by: JU4N98 <juanpablocabana2@gmail.com>
@faisal-memon
Copy link
Collaborator

Thanks @JU4N98 for submitting this.

@faisal-memon faisal-memon self-assigned this Jun 18, 2023
JU4N98 and others added 2 commits June 18, 2023 02:56
@JU4N98 @faisal-memon
Update pkg/sidecar/sidecar.go
89c8e69 
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Juan Pablo Cabaña <46539158+JU4N98@users.noreply.github.com>
@faisal-memon
Merge branch 'main' into update-certs-on-empty-cmd
123060c
@faisal-memon faisal-memon merged commit 2adaa03 into spiffe:main Jun 18, 2023
FedeNQ pushed a commit to FedeNQ/spiffe-helper-fede that referenced this pull request Jun 26, 2023
@JU4N98 @faisal-memon @FedeNQ
Skip process signaling if cmd field is empty (spiffe#73)
a7fe141 
* Skip process signaling if cmd field is empty or not defined.

Signed-off-by: JU4N98 <juanpablocabana2@gmail.com>

* Update pkg/sidecar/sidecar.go

Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Juan Pablo Cabaña <46539158+JU4N98@users.noreply.github.com>

---------

Signed-off-by: JU4N98 <juanpablocabana2@gmail.com>
Signed-off-by: Juan Pablo Cabaña <46539158+JU4N98@users.noreply.github.com>
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
FedeNQ pushed a commit to FedeNQ/spiffe-helper-fede that referenced this pull request Jun 26, 2023
@JU4N98 @faisal-memon @FedeNQ
Skip process signaling if cmd field is empty (spiffe#73)
1626d74 
* Skip process signaling if cmd field is empty or not defined.

Signed-off-by: JU4N98 <juanpablocabana2@gmail.com>

* Update pkg/sidecar/sidecar.go

Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Juan Pablo Cabaña <46539158+JU4N98@users.noreply.github.com>

---------

Signed-off-by: JU4N98 <juanpablocabana2@gmail.com>
Signed-off-by: Juan Pablo Cabaña <46539158+JU4N98@users.noreply.github.com>
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

Assignees

@faisal-memon faisal-memon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JU4N98 @faisal-memon