add missing files to fix docker build #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-memon
approved these changes
May 3, 2024
There was a problem hiding this comment.
Thanks @gflarity . Just need to fix up the DCO and then we can merge this.
That would be a great addition if you have the time for it. |
Signed-off-by: Geoff Flarity <geoff@centml.ai>
gflarity
force-pushed
the
gflarity/fix_docker_build
branch
from
75a3b1e
to
1106875
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like commit eb7a20 broke the docker build (via theDockerfile). Previously only main.go was COPY'd in the docker file.
Fix is simple, just COPY the whole cmd/spiffe-helper directory rather than just the main.go.
Looks like the nightly builds have been failing. One suggestion might to add building the docker image to the pr_build tests. I can take a stab at this if desired, I'd mostly just cut and paste from the nightly build minus the pushing.
Thanks,
Geoff