Update Config Files with SPIRE Agent Default Socket Path and Fix README.md Table Formatting
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxlambrecht Thanks for submitting this. Will it close #36? |
I'm not sure, this PR aligns the socket path in config files and docs with SPIRE's default, but it overlooks incorporating support for the standard environment variable to define that path. |
faisal-memon
approved these changes
Dec 20, 2023
|
@maxlambrecht can you rebase? |
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
update-conf-socket
branch
from
7c761f0
to
274538a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to all configuration files, changing the SPIRE agent socket path to the default
"/tmp/spire-agent/public/api.sock". Additionally, adjustments have been made to fix the formatting of the table in theREADME.mdfile.