Fix panic when create spidermultusconfig with nil podRPFilter in validate webhook #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
added
cherrypick-release-v0.8
cyclinder
requested review from
weizhoublue,
ty-dc and
bzsuni
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
==========================================
+ Coverage 80.83% 80.88% +0.04%
==========================================
Files 51 51
Lines 4514 4514
==========================================
+ Hits 3649 3651 +2
+ Misses 699 698 -1
+ Partials 166 165 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
cyclinder
force-pushed
the
spidermultusconfig/fix_panic
branch
from
06385b5
to
b8e67d7
Compare
ty-dc
reviewed
Sep 14, 2024
| }).WithTimeout(time.Minute * 3).WithPolling(time.Second * 5).Should(BeNil()) | ||
| }) | ||
|
|
||
| It("set hostRPFilter and podRPFilter to a invalid value", Label("M00023"), func() { |
There was a problem hiding this comment.
这里有 M00023 ，但是 test/doc 中缺少用例。
ty-dc
reviewed
Sep 14, 2024
| @@ -23,4 +23,5 @@ | |||
| | M00019 | set spidermultusconfig.spec to empty and see if works | p3 | | done | | | |||
| | M00020 | annotating custom names that are too long or empty should fail | p3 | | done | | | |||
| | M00021 | create a spidermultusconfig and pod to verify chainCNI json config if works | p3 | | done | | | |||
| | M00022 | test podRPFilter and hostRPFilter in spidermultusconfig | p3 | | done | | |||
cyclinder
force-pushed
the
spidermultusconfig/fix_panic
branch
from
b8e67d7
to
f8271d2
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
spidermultusconfig/fix_panic
branch
from
f8271d2
to
bc0f86a
Compare
weizhoublue
approved these changes
Sep 19, 2024
ty-dc
approved these changes
Sep 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Fix panic when create spidermultusconfig with nil podRPFilter in validate webhook Signed-off-by: robot <tao.yang@daocloud.io>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Fix panic when create spidermultusconfig with nil podRPFilter in validate webhook Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4061
Special notes for your reviewer: