Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick some CI changes #4032

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Sep 5, 2024

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4027

Special notes for your reviewer:
cherry-pick https://github.com/spidernet-io/spiderpool/pull/3925,clean 是属于新功能,不需合入到 release-v0.8。

基于 #3925 ,在 release-v0.8 上修改一些 CI 问题,如:

  1. makefile 语法使用有误 -$(QUIET) make -C test uninstall_spiderpool,错误使用了 '-',导致忽略了 uninstall_spiderpool 层级下的报错。
  2. 明确 CI 卸载或者更新在哪一步失败了 ,调整 CI 结构

@ty-dc ty-dc force-pushed the release-v0.8 branch 2 times, most recently from 4aefa1b to b99c4da Compare September 9, 2024 02:02
@ty-dc ty-dc removed the pr/not-ready not ready for merging label Sep 9, 2024
Signed-off-by: tao.yang <tao.yang@daocloud.io>
@ty-dc ty-dc closed this Sep 10, 2024
@ty-dc ty-dc reopened this Sep 10, 2024
@ty-dc ty-dc merged commit 49e2efd into spidernet-io:release-v0.8 Sep 10, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants