Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: egw uses the EIP count function #980

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

biqiangwu
Copy link
Contributor

fix: #838

@biqiangwu biqiangwu added the release/feature-new feature pr recoded in new release label Nov 14, 2023
@weizhoublue
Copy link
Collaborator

weizhoublue commented Nov 14, 2023

@weizhoublue weizhoublue temporarily deployed to pull request November 14, 2023 09:06 Inactive
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #980 (0f0b1d3) into main (0fc60b5) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   44.01%   43.24%   -0.77%     
==========================================
  Files          20       20              
  Lines        3092     3147      +55     
==========================================
  Hits         1361     1361              
- Misses       1530     1585      +55     
  Partials      201      201              
Flag Coverage Δ
unittests 43.24% <0.00%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/utils/ip/ip.go 66.20% <0.00%> (-11.79%) ⬇️

lou-lan
lou-lan previously approved these changes Nov 14, 2023
bzsuni
bzsuni previously approved these changes Nov 14, 2023
@biqiangwu biqiangwu dismissed stale reviews from bzsuni and lou-lan via ea58386 November 15, 2023 01:31
@weizhoublue weizhoublue temporarily deployed to pull request November 15, 2023 01:32 Inactive
@weizhoublue
Copy link
Collaborator

@bzsuni 的100 ip 用例中,可以 加入对 usage 的校验,一起闭环 用例

@weizhoublue
Copy link
Collaborator

kubectl get -o wide 能显示 用量和总量

@bzsuni
Copy link
Collaborator

bzsuni commented Nov 17, 2023

@bzsuni 的100 ip 用例中,可以 加入对 usage 的校验,一起闭环 用例

好的

@biqiangwu
Copy link
Contributor Author

kubectl get -o wide 能显示 用量和总量

这个留着后面做吧,这个PR 先合了?

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
@weizhoublue weizhoublue temporarily deployed to commit November 21, 2023 09:51 Inactive
@bzsuni bzsuni force-pushed the feat/add_egw_uses_ip_count branch 2 times, most recently from 61f026e to c3e7a8e Compare November 21, 2023 10:35
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
lou-lan
lou-lan previously approved these changes Nov 23, 2023
@bzsuni
Copy link
Collaborator

bzsuni commented Nov 23, 2023

kubectl get -o wide 能显示 用量和总量

done

# kubectl get egw
NAME                 IPV4DEFAULTEIP   IPV6DEFAULTEIP   CLUSTERDEFAULT   IPV4TOTAL   IPV4FREE   IPV6TOTAL   IPV6FREE
test-egressgateway   10.6.1.88        fddd:10::1e                       91          87         91          87

@lou-lan lou-lan merged commit 225d790 into main Nov 24, 2023
35 of 36 checks passed
@lou-lan lou-lan deleted the feat/add_egw_uses_ip_count branch November 24, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new feature pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ feature ] egw 需要有 IP 使用情况展示
4 participants