Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & cleanup nettools code #257

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

cyclinder
Copy link
Collaborator

fix & cleanup nettools code:

  • using flag parse
  • goroutine leak
  • support ipv6

@cr-gpt
Copy link

cr-gpt bot commented Mar 29, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

lou-lan
lou-lan previously approved these changes Mar 29, 2023
@lou-lan lou-lan added the release/bug bug pr recoded in new release label Mar 29, 2023
@lou-lan lou-lan requested a review from biqiangwu March 29, 2023 10:30
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #257 (d0e8414) into main (73224cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   31.30%   31.30%           
=======================================
  Files          11       11           
  Lines        2233     2233           
=======================================
  Hits          699      699           
  Misses       1444     1444           
  Partials       90       90           
Flag Coverage Δ
unittests 31.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cr-gpt
Copy link

cr-gpt bot commented Mar 29, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cyclinder cyclinder merged commit f5c20f0 into spidernet-io:main Mar 29, 2023
@cyclinder cyclinder deleted the bug/nettools branch March 30, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/bug bug pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants