Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iptables rule match criteria #250

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update iptables rule match criteria #250

merged 1 commit into from
Mar 30, 2023

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Mar 29, 2023 •
edited
Loading

Fix #243

@spidernet-io spidernet-io deleted a comment from cr-gpt bot Mar 29, 2023
@lou-lan lou-lan changed the title Update match criteria Update iptables rule match criteria Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #250 (e8960dd) into main (f5c20f0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   31.30%   31.27%   -0.04%     
==========================================
  Files          11       11              
  Lines        2233     2232       -1     
==========================================
- Hits          699      698       -1     
  Misses       1444     1444              
  Partials       90       90
Flag Coverage Δ
unittests 31.27% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/police.go 48.34% <100.00%> (-0.08%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
33.3% 33.3% Duplication

@spidernet-io spidernet-io deleted a comment from cr-gpt bot Mar 30, 2023
@spidernet-io spidernet-io deleted a comment from cr-gpt bot Mar 30, 2023
@weizhoublue weizhoublue merged commit 48650eb into main Mar 30, 2023
@weizhoublue weizhoublue deleted the iptables branch March 30, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biqiangwu biqiangwu biqiangwu approved these changes

@weizhoublue weizhoublue Awaiting requested review from weizhoublue weizhoublue is a code owner

@bzsuni bzsuni Awaiting requested review from bzsuni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can egressgateway and metallb work together?
3 participants
@lou-lan @biqiangwu @weizhoublue